On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K <k...@openjdk.org> wrote:

> Cause: On hiding the DatePicker dropdown, value selected was not getting 
> updated to the text editor. Hence old value from the text editor was getting 
> committed to DatePicker on focus loss. This issue was seen only when 
> DatePicker is used in Alert dialog and Alert dialog is closed on making 
> selection in DatePicker dropdown.
> 
> Fix: Added call to updateDisplayNode() function before hiding the date picker 
> dropdown.
> 
> Test: Added system test to validate the fix.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java
 line 145:

> 143:                 show();
> 144:             } else {
> 145:                 updateDisplayNode();

Can the call to `updateDisplayNode();` be removed in line 128 then?
Just asking, since `updateDisplayNode();` is now called two times. But it looks 
like this is also still needed..

-------------

PR: https://git.openjdk.org/jfx/pull/963

Reply via email to