On Thu, 8 Dec 2022 19:38:02 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Revert renames in Disposer
>
> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/PropertyDescriptor.java
>  line 177:
> 
>> 175:             if (bean.equals(propertyChangeEvent.getSource()) && 
>> name.equals(propertyChangeEvent.getPropertyName())) {
>> 176:                 final ReadOnlyJavaBeanProperty<T> property = checkRef();
>> 177:                 if ((property instanceof Property) && 
>> (((Property<?>)property).isBound()) && !updating) {
> 
> This line can be
> 
> if ((property instanceof Property<?> prop) && prop.isBound() && !updating) {
> 
> with perhaps better naming.

Yes, good suggestion, changed.

-------------

PR: https://git.openjdk.org/jfx/pull/969

Reply via email to