On Tue, 3 Jan 2023 09:46:51 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> Looks good to me. Tested on Windows10 and verified that not setting > `observer` to `null` does not lead to any leak. Please merge with latest > master to trigger a GitHub build and test. Thanks, I've merged in master. > Under a different bug, should we implement the `dispose()` method? Track all > observables in a Weak list and remove `observer` from them in `dispose()` Perhaps, currently only more specific implementations (provided mainly by `Bindings`) do this. I think it was left up to the subclass to decide whether this would be worth it in order to keep bindings as light weight as possible. `dispose` certainly makes no promises in that regard (it basically makes no promises at all after reading the docs). ------------- PR: https://git.openjdk.org/jfx/pull/198
