On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko <rmarche...@openjdk.org> wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode) >> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 >> >> >> GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't >> adapted after GraphicsContext's refactoring integration into JFX. As the >> result, the methods were not invoked, so TransparencyLayer couldn't be added >> to a rendering queue. >> >> Now the methods are fixed to be used properly in GraphicsContext inheritance >> chain. > > Roman Marchenko has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains one commit: > > Fixed the opacity issue +looks good to me The patch looks ok, as [GraphicsContextJava.h] needs to inherit methods from GraphicsContext.h , the begin/endPlatformTransparencyLayers already modified in latest update. so it looks like there would not be conflict. ------------- Marked as reviewed by jbhaskar (Author). PR: https://git.openjdk.org/jfx/pull/992
