On Tue, 31 Jan 2023 23:04:50 GMT, Scott Palmer <[email protected]> wrote:
> Is it necessary for any application to know about "auto"? I actually don't know how the "auto" behaves. From the description it seems the colors might actually change gradually throughout the day, thus making an enum useless and necessitating the use of the actual colors. ***@***.*** -andy From: Scott Palmer ***@***.***> Date: Tuesday, January 31, 2023 at 15:05 To: openjdk/jfx ***@***.***> Cc: Andy Goryachev ***@***.***>, Comment ***@***.***> Subject: [External] : Re: [openjdk/jfx] 8301302: Platform preferences API (PR #1014) On Tue, Jan 31, 2023 at 3:00 PM Andy Goryachev ***@***.***> wrote: > In the context of adding theme support in javafx, I think this PR is a > step in the right direction. I also like a small set of > platform-independent properties like fg and bg colors. I wonder if the same > approach can be extended for other aspects of platform L&F, like fonts, > spacing, and may be other aspects (like, hiding scrollbars setting on Mac?) > > I agree with @kevinrushforth > <https://github.com/kevinrushforth><https://urldefense.com/v3/__https:/github.com/kevinrushforth*3E__;JQ!!ACWV5N9M2RV99hQ!KHKaL2kyeeUaTInIrS8Uhsv6ERm_8WkoL8AnRSjL0wrZHd7sAwYhgS-04iFgvIaFFG8jBOn21R4qDKP5cQK_qehehGOxHA$> > - we'd > need more discussion on the actual implementation. There are a few items > that I feel are unnecessary, or might be done differently, and I'd like to > learn what other people think. > > Specifically: > > 1. Appearance enum seems unnecessary - there might be more choices in > a specific platform (Mac Ventura has three: dark/light/auto). > > Is it necessary for any application to know about "auto"? Presumably when the mode automatically changes from one to the other there would be an event that should be handled, just as if the user changed the setting while the application was running. Scott > Message ID: ***@***.***> > — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/openjdk/jfx/pull/1014*issuecomment-1411193097__;Iw!!ACWV5N9M2RV99hQ!KHKaL2kyeeUaTInIrS8Uhsv6ERm_8WkoL8AnRSjL0wrZHd7sAwYhgS-04iFgvIaFFG8jBOn21R4qDKP5cQK_qejGo1dBdQ$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AZQ34ZCIPVHZMVEXMC2WO7TWVGLB7ANCNFSM6AAAAAAUJ6L3R4__;!!ACWV5N9M2RV99hQ!KHKaL2kyeeUaTInIrS8Uhsv6ERm_8WkoL8AnRSjL0wrZHd7sAwYhgS-04iFgvIaFFG8jBOn21R4qDKP5cQK_qehZTOIwSA$>. You are receiving this because you commented.Message ID: ***@***.***> ------------- PR: https://git.openjdk.org/jfx/pull/1014
