On Thu, 9 Feb 2023 09:37:33 GMT, Karthik P K <k...@openjdk.org> wrote:
>> While checking for duplicate series addition to the line chart, >> `setToRemove` value was not considered before throwing exception. Hence code >> to handling the case of adding the removed series was never run. >> >> Added condition to check `setToRemove` boolean value before throwing >> exception. Made changes to call `setChart` method after calling >> `seriesBeingRemovedIsAdded`. Otherwise chart will not be drawn for the >> series, only points will be plotted. >> >> This issue is reproducible only when animation is enabled because timeline >> will be still running when removed series is added back to the same chart. >> Since timeline does not run in unit tests, added system test to validate the >> fix. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing review comments asking for one change. ------------- Changes requested by angorya (Committer). PR: https://git.openjdk.org/jfx/pull/1015
