On Wed, 22 Feb 2023 14:13:35 GMT, Karthik P K <[email protected]> wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed code to scroll to top before popup display when content height of
>> `ChoiceBox` is smaller than the scrolled offset.
>>
>> Added system test to validate the fix.
>
> Karthik P K has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address review comments
tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
line 108:
> 106: private void showChoiceBox() throws Exception {
> 107: mouseClick(choiceBox.getLayoutX() + choiceBox.getWidth() / 2,
> 108: choiceBox.getLayoutY() + choiceBox.getHeight() / 2);
are these two lines slightly misaligned?
perhaps we could convert this to
double x = ...;
double y = ...;
mouseClick(x, y);
(there is a value in having one statement per line, in general)
-------------
PR: https://git.openjdk.org/jfx/pull/1039
