On Sun, 19 Feb 2023 18:29:16 GMT, Thiago Milczarek Sayao <[email protected]>
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any size because it varies - it does cache because
>> it's unlikely to vary on the same system - but if it does occur, it will
>> only waste a resize event.
>> - window geometry, min/max size are centralized in
>> `update_window_constraints`;
>> - Frame extents (the window decoration size used for "total window size"):
>> - frame extents are received in `process_property_notify`;
>> - removed quirks in java code;
>> - When received, call `set_bounds` again to adjust the size (to account
>> decorations later received);
>> - Removed `activate_window` because it's the same as focusing the window.
>> `gtk_window_present` will deiconify and focus it.
>> - `ensure_window_size` was a quirk - removed;
>> - `requested_bounds` removed - not used anymore;
>> - `window_configure` incorporated in `set_bounds` with `gtk_window_move` and
>> `gtk_window_resize`;
>> - `process_net_wm_property` is a work-around for Unity only (added a check
>> if Unity - but it can probably be removed at some point)
>> - `restack` split in `to_front()` and `to_back()` to conform to managed code;
>> - Set `gtk_window_set_focus_on_map` to FALSE because if TRUE the Window
>> Manager changes the window ordering in the "focus stealing" mechanism - this
>> makes possible to remove the quirk on `request_focus()`;
>> - Note: `geometry_get_*` and `geometry_set_*` moved location but unchanged.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Re-fix initial size
I ran a full set of headful tests on both Ubuntu 20.04 and 22.04. The only
remaining problem I see is a new failure on one test on both platforms:
$ gradle --info -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
CheckWindowOrderTest
CheckWindowOrderTest > topWindowShouldBeTheLast FAILED
java.lang.AssertionError: Last Window Should be Focused
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at
test.robot.javafx.stage.CheckWindowOrderTest.topWindowShouldBeTheLast(CheckWindowOrderTest.java:57)
That test passes without the patch from this PR.
-------------
PR: https://git.openjdk.org/jfx/pull/915
