> Issue was observed because even when graphic height was less than text height 
> of the Label, graphic height was considered while calculating the baseline 
> offset. This was shifting the baseline offset and resulted in misalignment.
> 
> Updated `computeBaselineOffset` to exclude graphic height from baseline 
> offset calculation when graphic height is more than text height.
> 
> Added unit test to validate the fix.

Karthik P K has updated the pull request incrementally with one additional 
commit since the last revision:

  Update comment

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1059/files
  - new: https://git.openjdk.org/jfx/pull/1059/files/85f84c22..8e733c58

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1059&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1059&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1059.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/1059/head:pull/1059

PR: https://git.openjdk.org/jfx/pull/1059

Reply via email to