On Sat, 11 Mar 2023 14:28:31 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8303740
>> Added changes based on code review
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/Logging.java line 32:
>
>> 30: public class Logging {
>> 31:
>> 32: public static boolean keepException = false;
>
> I'd rather see a private field and a public setter/getter here. Please also
> add a comment on the setter/getter indicating that they are only used for
> testing.
done
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/TestLogging.java
> line 1:
>
>> 1: package test.com.sun.javafx.binding;
>
> You need to add a standard copyright header.
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1053#discussion_r1145847263
PR Review Comment: https://git.openjdk.org/jfx/pull/1053#discussion_r1145847602
