Or, rather than removing the check entirely, make it a warning.

-- Kevin


On 3/31/2023 9:03 AM, John Neffenger wrote:
On 3/30/23 11:17 AM, Glavo wrote:
I compiled OpenJFX for RISC-V and MIPS64el platforms with reference to your patch, thereby porting our JavaFX applications to these platforms, and it worked well.

A better patch, then, would be to remove the platform test entirely so that there are no unsupported build architectures. In other words, remove this failure:

  fail("Unknown and unsupported build architecture: $OS_ARCH")

My current patch is too conservative and just extends the list of supported architectures. I'll keep that in mind when I create the pull request (unless anyone else beats me to it).

allow-armhf-i386-ppc64el-s390x.patch
https://github.com/jgneff/openjfx/blob/edge/snap/local/allow-armhf-i386-ppc64el-s390x.patch

Thanks,
John


Reply via email to