On Mon, 3 Apr 2023 16:19:47 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> tests/manual/events/KeyboardTest.java line 79:
>
>> 77: */
>> 78:
>> 79: public class KeyboardTest extends Application {
>
> Could you clarify how to run the test and what one should expect?
>
> In my case, I'm running from Mac, with a Spanish physical keyboard, but
> changed to German keyboard from Keyboard -> Input sources -> German, and
> whether the Keyboard viewer is visible or not, I get:
>
> [Mac] Testing 78 keys on German without combinations
> Failed: code Numpad 0 did not produce any events
> ...
> Failed: code Decimal did not produce any events
> Tested 78 keys with 76 failures
>
> Is that expected? Is that test only meant for a German keyboard?
@jperedadnr You set up the test correctly. I think you need to need to allow
the 'terminal' application to use the accessibility API so the Java robot can
send keyboard events. I can't provide you with the exact setting since I'm away
from my Mac until the end of this week. When I get back I'll send details and
add a comment to the test file. Apologies, I set up my Mac so long ago I forgot
about this hiccup.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1156524005
