On Thu, 6 Apr 2023 11:48:58 GMT, Jose Pereda <jper...@openjdk.org> wrote:

> I wonder if RobotKeySanityTest could be part of the PR as a manual test? Same 
> as in #694

The RobotKeySanityTest is tricky, it requires the user to press a lot of keys 
to get good coverage but can produce confusing results if the user presses 
certain keys, like AltGr. Windows treats AltGr as if you pressed Ctrl and Alt 
at the same time. This means the OS sends two events when you press the key and 
two more when you release it. This is confusing the RobotKeySanityTest which 
can only handle one press/release pair at a time. I'm not sure I can fix the 
test but will think about it.

The KeyboardTest app that I recently added to PR #425 covers most of the same 
ground and avoids the problematic keys. The downside of KeyboardTest is that it 
only provides good coverage for specific layouts (I'll try to add Spanish) and 
provides the best coverage when run against multiple layouts which takes effort 
to set up.

I've written an app that just logs key events as the user types and that would 
probably be a better candidate to attach to some PR. When something confusing 
happens with RobotKeySanityTest or KeyboardTest that's the app I pull up to 
diagnose what's going on (like I just did with AltGr).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/702#issuecomment-1500530373

Reply via email to