On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> Fixes three issues in ExpressionHelper: > > - Current Value was not retained when changing from SingleChange to Generic, > this can lead to missed changes > - Current Value was not retained when changing from Generic to SingleChange, > this can lead to missed changes > - Current Value was not cleared when last change listener was removed in > Generic variant, resulting in an older value being referenced and not > becoming eligible for GC until either a ChangeListener is added again, or > sufficient InvalidationListeners are removed to switch to the > SingleInvalidation implementation... Yes. I'm in the middle of reviewing another PR, so this will be the next one. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1078#issuecomment-1500679355