On Fri, 3 Mar 2023 01:13:49 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> This PR does: >> >> - Remove specific Idea files and let it be imported from gradle; >> - Adds checkstyle (to use with checkstyle plugin - it will let you know >> style mistakes); >> - Configures auto-format to sun style (with the changes mentioned in [Code >> Style Rules](https://wiki.openjdk.org/display/OpenJFX/Code+Style+Rules)); >> - Automatically sets Copyright notice (updates year too); >> - Run configurations for samples/toys and builds. > > Thiago Milczarek Sayao has updated the pull request incrementally with two > additional commits since the last revision: > > - Revert "Make intellij see :systemTests dependecies" > > This reverts commit dca7eab24958e1214147b7d291f0faf52ea27ddf. > - Make intellij see :systemTests dependecies > I've reverted the gradle changes, so it pretty much only affect the IDE. Good. I'll let the IntelliJ users do the review. My only comments are on the two files outside the `.idea` directory. .gitignore line 57: > 55: > 56: # IntelliJ > 57: out/ This would pick up more than just IntelliJ files. Are they all needed? .gitignore line 67: > 65: > 66: #mac folder > 67: .DS_Store These seem unrelated to this PR (and in the case of `hs_err`, there is a typo). checkstyle.xml line 1: > 1: <?xml version="1.0"?> I'm not keen on adding yet another top-level file in our repo. Can it go somewhere else? ------------- PR Review: https://git.openjdk.org/jfx/pull/1009#pullrequestreview-1376645064 PR Review Comment: https://git.openjdk.org/jfx/pull/1009#discussion_r1161003425 PR Review Comment: https://git.openjdk.org/jfx/pull/1009#discussion_r1161003615 PR Review Comment: https://git.openjdk.org/jfx/pull/1009#discussion_r1161004078
