On Thu, 30 Mar 2023 22:25:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This was clearly a mistake back when the public API was first created in JDK >> 9. > >> @kevinrushforth I've created the CSR for this. Can I move it to proposed? > > I took a quick look, and it is fine to move to Proposed. @kevinrushforth about the CSR -- as I couldn't move the classes to non-public hierarchy, I think the CSR is currently correct. I also removed a public method in `SimpleSelector` as it wasn't used (and as discussed before, nobody can reach it without casting). There were a few javadoc only changes that could be seen as clarification (whether something can be `null` or whether it is immutable). I could include those in the CSR. If we want to move forward later to perhaps try and remove `SimpleSelector` and `CompoundSelector` (perhaps by adding those few public API methods to `Selector`), I could already mark these deprecated (or I could do so to indicate they shouldn't be used at all, whether we want to remove them or not). What do you think? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1070#issuecomment-1500982072
