On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

> BitSet uses the SetListenerHelper abstraction to prevent allocating the 
> listener arrays.
> 
> When removing listeners, the newly returned listener helper (which may be 
> different from the one called) is not reassigned. This effectively means that 
> removing the listener does not happen.
> 
> This fix correctly assigns the potentially changed SetListenerHelper instance 
> to BitSet's helper field after listener removal.

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1071#pullrequestreview-1378109599

Reply via email to