On Mon, 10 Apr 2023 23:55:51 GMT, Martin Fox <d...@openjdk.org> wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead >> key) the glass code will dynamically query the key's unshifted character to >> determine the Java code to assign to it. This is necessary since the >> relationship between OEM key codes and the characters they generate varies >> from layout to layout. >> >> The Robot implementation was consulting a table which assumed a fixed >> relationship between Java codes and Windows key codes even for the OEM keys. >> The table was also missing entries for any Java code not on a US QWERTY >> layout, like PLUS. >> >> In this PR if we don't find the Java code in the table or if it maps to an >> OEM key (which may be wrong) we sweep through all the OEM keys looking for >> the matching Java code. > > Martin Fox has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Coding style consistency > - Merge remote-tracking branch 'upstream/master' into winrobot > - Updated license header copyrights > - A Robot now correctly handles KeyCodes that aren't in the current layout > - Robot now targets punctuation and symbol keys reliably Marked as reviewed by jpereda (Reviewer). ------------- PR Review: https://git.openjdk.org/jfx/pull/702#pullrequestreview-1378714800
