On Mon, 17 Apr 2023 03:08:27 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> revert a change in Menu
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TableColumnBase.java
> line 738:
>
>> 736: * <p>
>> 737: * The {@code TableColumnBase} class allows registration of
>> listeners which will be notified when editing occurs.
>> 738: * Note that {@code TableColumnBase} is <b>not</b> a {@link Node},
>> and therefore no visual events will be fired on it.
>
> Isn't this true for the other classes here as well, like `Tab`? Might it be
> worth saying this in the other classes too then, or even on `EventTarget`
> itself (something like "Note that implementing classes that are not a `Node`
> don't receive visual events")?
> I would also give an example or 2 of what "visual events" are since this term
> is not defined anywhere that I know of.
I don't know what "visual events" are, maybe input events?
Anyway, the added value of this entire javadoc seems to be rather low, I'm
inclined to just remove it entirely.
By the way, there's a great documentation of the JavaFX event system at
https://docs.oracle.com/javase/8/javafx/events-tutorial/events.htm. It would be
really helpful if we could add this to the JavaFX codebase in the future.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1090#discussion_r1168159255
