On Sun, 9 Apr 2023 22:48:22 GMT, Nir Lisker <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>>
>> - Added extra tests cases that count invalidations
>> - Added explanatory comment
>
> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueWhenTest.java
> line 260:
>
>> 258: assertEquals(0, observedInvalidations.get());
>> 259:
>> 260: when.getValue(); // would make no difference, inactive
>> when bindings are always valid
>
> Did you mean "always valid when bindings are inactive"? Or maybe that when
> the binding is valid the listener is inactive? This sentence is confusing to
> me.
:-) The confusing part is because I referred to the `when` construct here.
I've changed it to:
// would make no difference, inactive "when" bindings are always valid
I also put quotes around the other uses where necessary.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1056#discussion_r1168536579
