On Mon, 24 Apr 2023 23:37:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java >> line 51: >> >>> 49: // empty - not needed by this implementation >>> 50: @Override >>> 51: protected native void _updateViewSize(long ptr); >> >> Is there a system test that can be used to verify these changes on Linux? >> Since you have mentioned this is the same as #1054, I take that >> SetSceneScalingTest can be used. >> >> Also, I'm not sure how you would run WinIconified test attached to the JBS >> ticket to see that it fails or passes. If that can be converted to system >> test, could you add it to this PR? > > I noticed this earlier, and filed > [JDK-8298500](https://bugs.openjdk.org/browse/JDK-8298500) to improve our > test coverage in this area. > > It would be good to make sure that we have a test that does this for at least > an inconified window to help validate this PR. I could do a Iconified test, but I think it would not test the case that happened before, the window pops (because of `requestFocus`) and then gets iconified (the user sees the window showing then iconifying). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1175887641
