On Thu, 27 Apr 2023 15:27:14 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Print seed if test fails
>> - Merge branch 'master' into feature/ceil-fix
>> - Fix Region ceil/floor function guarantees to be more accurate
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionTest.java
> line 1290:
>
>> 1288: stage.setRenderScaleX(scale);
>> 1289: for (int j = 0; j < 1000; j++) {
>> 1290: double value = new Random().nextDouble() *
>> Integer.MAX_VALUE;
>
> I'd suggest to set and **print** random seed here and on line 1300. If the
> test ever fails with some random value, we should be able to reproduce the
> issue using that particular seed.
>
> (+ use the same Random instance in the second part of the test)
I've changed this. It now prints the seed only if there is a failure.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1118#discussion_r1179574729
