On Tue, 9 May 2023 22:31:53 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 136 changed files > > modules/javafx.graphics/src/main/java/com/sun/javafx/application/ParametersImpl.java > line 1: > >> 1: /* > > Removing unused constructors (and their dependent methods) will require > someone to look at why they aren't used. These are just oversights. Any large code base that has evolved without enforcing warnings will be full of them because they're easy to miss. There is quite some unused code in private methods, and there will probably be far more when public methods (in private packages) are included in this analysis. I only removed it in this case because fixing raw type warnings in unused code is not very useful. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1095#discussion_r1191055148
