On Wed, 10 May 2023 16:14:43 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> The problem is, `dispose()` is never called for cells discarded by the 
>> refresh() method.
>> 
>> In the absence of explicit release, these cells are still listening - so 
>> using a weak listener in this case is, I think, the right approach.  Adding 
>> explicit release per your (absolutely valid) suggestion is a good idea, but 
>> much, much more complicated task.
>
> Even if you are using weak listeners, `dispose` should remove them.

revered back to using register*Listener, which creates a weak listener and also 
disconnects them in dispose()

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1191748091

Reply via email to