On Sat, 13 May 2023 17:23:55 GMT, Carl Döbbelin <d...@openjdk.org> wrote:

>> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
>
> Carl Döbbelin has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   refactored HostUtils

`isEmbedded()` is also unused as far as I can tell.

The question is why this and `is64bit` were created. Before removing unused 
code I would try to find out if it is *supposed* to be used.

> i think it may be a valid option to replace calls of HostUtils by calls of 
> PlatformUtil and move is64bit in the PlatformUtil as well. It may also be an 
> option to remove it completely.

This is what I would have done. No need to have duplicate functionalities.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1134#issuecomment-1546715646

Reply via email to