On Wed, 17 May 2023 21:20:28 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 532:
>
>> 530: return true;
>> 531: }
>> 532: if (obj instanceof BitSet<?> bitSet) { // fast path if other
>> is a BitSet
>
> I think we may need to add a 'component type' to BitSet, to make sure than
> BitSet<A> never intersects with BitSet<B>.
>
> (Didn't we do it already, may be in some other PR?)
We did, in #1076. However, I would like to not pull in all the `BitSet` fixes
into this PR as this has nothing to do with `BitSet` and its many problems.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1070#discussion_r1197097814
