> This issue happened because `childSet` member of Parent was modified during > `onProposedChange()` call - that call did not recognize negative indexes as > invalid, which caused an exception when actually adding the Node to a List. > > This seemed like the simplest solution which doesn't rework a lot of code > underneath. Exceptions coming from a backing list/collection technically are > handled by `VetoableListDecorator`'s try-catch clauses, however > `VetoableListDecorator` does not provide an interface to react when such an > exception happens - without it we cannot revert `childSet` back to its > original state.
Lukasz Kostyra has updated the pull request incrementally with two additional commits since the last revision: - ParentTest: Add tests for NPE and *All calls - ObservableListWrapper: Add from-to index check to remove(int, int) ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1136/files - new: https://git.openjdk.org/jfx/pull/1136/files/63023839..f1a8797d Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1136&range=02 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1136&range=01-02 Stats: 36 lines in 2 files changed: 36 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1136.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1136/head:pull/1136 PR: https://git.openjdk.org/jfx/pull/1136
