On Fri, 19 May 2023 00:10:25 GMT, John Hendrikx <[email protected]> wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in >> the CSS API. Instead, `Set<PseudoClass>` should have been used. This PR >> corrects this. > > John Hendrikx has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains three > new commits since the last revision: > > - Add tests from #1076 > - Merge remote-tracking branch 'upstream/master' into > feature/remove-private-api-in-css > - Fix possible regression I've completed my review, and everything looks good. I found one missing doc change in the CSR (the change in SimpleSelector) that should be added, and then I'll formally review the CSR. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1070#pullrequestreview-1444402738
