On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The > solution for the failure is to compile 615.1 using the C++20 flag for Windows > (we will use this flag on all platforms for the next WebKit update). The fix > for that bug is necessarily included in this PR, since the two fixes as > interdependent. Btw, here is the output of cmake from our CI build listing the other tools that the WebKit build is using (you can look for the ones you use by searching for "cmake" in your log file at the start of the `:web:compileNativeWin` task). -- The C compiler identification is MSVC 19.35.32215.0 -- The CXX compiler identification is MSVC 19.35.32215.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: .../buildSrc/build/build-tools/devkit-windows_x64-VS2022-17.5.0+1.0.tar/VC/bin/x64/cl.exe - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: .../buildSrc/build/build-tools/devkit-windows_x64-VS2022-17.5.0+1.0.tar/VC/bin/x64/cl.exe - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- The CMake build type is: Release -- Found Perl: C:/cygwin/bin/perl.exe (found suitable version "5.32.1", minimum required is "5.10.0") -- Found PerlModules: TRUE found components: English FindBin JSON::PP -- Found Python: C:/cygwin/bin/python3.8.exe (found version "3.8.8") found components: Interpreter -- Could NOT find Ruby (missing: Ruby_INCLUDE_DIR Ruby_LIBRARY Ruby_CONFIG_INCLUDE_DIR) (found suitable version "2.6.4", minimum required is "1.9") -- Enabling ccache: Couldn't find ccache program. Not enabling it. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1142#issuecomment-1563620320
