On Mon, 22 May 2023 22:43:32 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Properly use NSObject instead of the GlassAccessible type. > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 124: > >> 122: >> 123: // Actions support >> 124: - (BOOL)performAccessibleAction:(jlong)actionId > > Would it make sense to have this parameter be an `NSString` (like the similar > method in `GlassAcessible`) and do the cast to `jlong` in this method rather > than having all the callers do it? Of course, that only works if all of the > calls will use NSString, so what you have is more flexible. Makes sense. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1084#discussion_r1212295158
