On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev <[email protected]> wrote:
>> Minor fixes and addition of missing sections: >> >> - The 'system' font is missing from the list of generic font family names in >> the <font> section. ✓ >> - Explicitly add text color property -fx-fill to Text section, so as not to >> confuse with Labeled -fx-text-fill ✓ >> - TextFlow section is missing, properties: -fx-text-alignment, >> -fx-line-spacing, -fx-tab-size ✓ >> - Text: missing -fx-line-spacing, -fx-bounds-type ✓ >> - -fx-focus-traversable is in Node and not in Control (though there is some >> relevant comment) - keep as is. ✓ >> - Node: broken link to 'Control' (sic, not Controls) in "... see Controls >> for details" ✓ >> - Missing <text-bounds-type> type ✓ > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > pane Can you add a new "Controls" section header? At the same time you can evaluate the suggestions from @hjohn modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1700: > 1698: <td class="range"> </td> > 1699: <td>The default value for controls is true, although there > are some exceptions. > 1700: See <a href="#control">Control</a> for details.</td> As noted by @Maran23 , this change should be reverted and a new section header for "Controls" should be added. ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1144#pullrequestreview-1455462317 PR Review Comment: https://git.openjdk.org/jfx/pull/1144#discussion_r1213144300
