On Thu, 8 Jun 2023 06:46:28 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1579:
>>
>>> 1577: @Test
>>> 1578: public void
>>> testComputeWidthShouldNotBeCalledWhenFixedCellSizeIsSet() {
>>> 1579: int cellSize = 24;
>>
>> magic number. setting cell size to 44 fails the test. cellSize=4 is ok.
>
> not per se a magic number in this context, as the VirtualFlow is resized to
> 300.
> So 13 cells fit inside it with this fixed cell size. Making it bigger will of
> course fail the test below.
Just changed the resize method to be `cellSize * 10`, so it is less of a magic
number in that case.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1150#discussion_r1222539247
