On Mon, 26 Jun 2023 13:41:24 GMT, Johan Vos <[email protected]> wrote:
> This PR fix a performance issue introduced by the fix for JDK-8306447. In
> that PR, we changed the behavior in case the cellcount changes. In case the
> cellcount changes to a lower value than the original one, we have to make
> sure the current index is not higher than the new amount of cells as that
> would lead to unnecessary computations.
>
> Fix for JDK-8310638
I'll look at the fix and test later. I noted one change that will be needed.
modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
line 2992:
> 2990: }
> 2991:
> 2992: protected int computeCurrentIndex() {
This would make this part of the exposed public API. It looks like you are just
using this for testing, so making it package scope is sufficient. Can you also
add a comment that this is used for testing?
-------------
Changes requested by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1163#pullrequestreview-1498577040
PR Review Comment: https://git.openjdk.org/jfx/pull/1163#discussion_r1242224815
