On Sun, 9 Jul 2023 18:10:05 GMT, Jose Pereda <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add newline at end of ConditionalBinding file
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableSubscriptionsTest.java
> line 57:
>
>> 55: value.set("B");
>> 56:
>> 57: assertEquals(1, calls.get());
>
> I'd add a comment here about: this works as long as `value` doesn't get
> validated again, i.e with a call to `value.get()`. (Imagine that someone is
> running tests and wants to add a printout of `value`...)
Yeah, the invalidation mechanism is sometimes tricky to test as observing the
property will alter the results :)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1069#discussion_r1257544069
