On Wed, 12 Jul 2023 22:33:44 GMT, Kevin Rushforth <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix subscriber -> valueSubscriber
>
> modules/javafx.base/src/test/java/test/javafx/beans/ObservableSubscriptionsTest.java
> line 68:
>
>> 66:
>> 67: value.get();
>> 68: value.set("C");
>
> Should this be a different value from the previously set one to ensure that
> an invalidation listener would get called if it were still subscribed?
Yes, that's not correct, fixed it, thanks
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1069#discussion_r1261830964
