On Thu, 20 Jul 2023 10:12:09 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Due to transient datatype of scenePeer, it can become null which can result
>> in NPE in scenarios where scene is continuously been reset and set, which
>> warrants a null check, as is done in other places for the same variable.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Check FXEnabled initially
tests/system/src/test/java/test/javafx/embed/swing/JFXPanelNPETest.java line 98:
> 96: });
> 97: SwingUtilities.invokeAndWait(JFXPanelNPETest::createUI);
> 98: for (int i = 0; i < 300; i++) {
I think this is way too long for a unit test. 300 iterations, 200 ms each = 60
seconds
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1178#discussion_r1271118367
