On Tue, 30 May 2023 15:37:29 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
> > Talking about #511 and #1014. I think that both the APIs are quite nice > > additions to JavaFX. However I was thinking, @mstr2 can't the two features > > be split? It seems to me, correct me if I'm wrong, that the Platform > > Preferences API still requires quite some work. On the other hand the > > support for themes seems to be easier and faster to implement. I think it > > would be worth splitting the two features, and trying to add the Theme API > > by the next release > > I've already proposed to deliver the feature in three installments to make it > easier to get it agreed upon and reviewed: > > 1. [Platform Preferences > API](https://bugs.openjdk.org/browse/JDK-8301302) (this PR) > > 2. [Allow Stage to control the appearance of window > decorations](https://bugs.openjdk.org/browse/JDK-8301303) > > 3. [Add CSS themes as a first-class > concept](https://bugs.openjdk.org/browse/JDK-8267546) > > > The Platform Preference API is ready to be reviewed, as far as I'm concerned. > While it has been discussed extensively on the mailing list and here on > GitHub, the feature proposal as a whole is still lacking buy-in from the > OpenJFX project leads. > > Note that getting the Style Theme API in before Platform Preferences is > harder than it sounds. The built-in JavaFX themes Caspian and Modena will > need to be re-implemented as first-class themes, and that requires Platform > Preferences to support high-contrast themes on Windows. The alternative of > keeping two different code paths would lead to significant additional > maintenance cost. I was hoping in getting at least the possibility of adding more than one stylesheet as the app user-agent, without necessarily implementing the Themes API yet. Guess I'll have to wait a bit more, in the meanwhile I'll try expanding my 'workaround' of converting multiple stylesheets to a single one on the fly to compensate And again, thanks for your work! ------------- PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1569803226
