On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. @kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost in one of my previous enhancements because of my mistake of setting this parameter to 1. I think that 1 reviewer is enough. By the way, the lighting in the LightingSample test application looks a bit off to me (regardless of this patch). It's as if the point and spot lights are too dim even at close range. Do you also notice that? Might need to look at previous revisions to see when it started, ------------- PR Comment: https://git.openjdk.org/jfx/pull/1186#issuecomment-1652865471