On Tue, 1 Aug 2023 13:46:15 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> That's true. However, `CssParser` is built around array-based sequences (see >> `StringConverter.SequenceConverter`), and changing these arrays to lists >> would seem out of place for this part of the codebase. What do you think? > > It depends on how much you want guarantees that they're not changed. I > suppose it's not that big of an issue. Changing to `List` is likely > impossible (I think that part of the API is public in places), only other > option than is to recreate the arrays if you want 100% certainty :) I think the risk is quite low, as the only way this could be changed is by acquiring the initial value of the `CssMetaData`, and then overwriting the array element. This shouldn't happen by accident. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1280908761
