On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Duplicate code removal I have finished my review and testing, and I think this fix is ready to go in. The code changes look good, and the rendering is now visually correct where it wasn't before. We should file a follow-up issue for the problem Andy pointed out (which partially affects Windows as well). I ran the attached test program on both Mac and Windows with and without this patch on a dual screen configuration with different scales for each screen. Without the patch, the rendering is incorrect on the secondary screen. With the patch the rendering is correct on both platforms. There are two problems that we need to address with a follow-up issue: 1. On Mac, the render scale and output scale of the window is reported as 1 on the primary retina screen. 2. On both Mac and Windows, the render scale and output scale of the window are not updated when the window moves from one screen to another, although it is re-rendered using the correct scale internally. The scales are being updated correctly in JFXPanel, but are not being propagated to the Window. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1171#pullrequestreview-1567558748
