On Fri, 18 Aug 2023 17:39:12 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> build.gradle line 4262:
>>
>>> 4260: options.addStringOption("-since-label").setValue("New API since
>>> JavaFX 9")
>>> 4261: options.addStringOption("Xmaxwarns").setValue("1000")
>>> 4262: options.addStringOption("Xmaxerrs").setValue("1000")
>>
>> would it make sense to treat warnings as errors? at least once we fix
>> JBS-TBD to fix all the warnings?
>
> Eventually, yes. Which is what I noted in the JBS issue.
>
> Btw, I filed [JDK-8314590](https://bugs.openjdk.org/browse/JDK-8314590) to
> track fixing all the warnings. A follow-up to _that_ issue will be to enable
> treating warnings as errors.
Thank you for clarification, Kevin!
I wish github would copy bug description from the ticket to the PR... I ddi not
bother to read JBS this time.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1216#discussion_r1298713048
