On Fri, 18 Aug 2023 20:23:04 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Correctly handle added node with multiple focuses
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8329:
>
>> 8327: set(true);
>> 8328: } else if (count == 0) {
>> 8329: set(false);
>
> This looks a bit odd due to the use of two different variables, but it works
> (`count > 0` would also have worked). I personally would favor something
> without any if statements as it leaves less room for misinterpretation in
> this case:
>
> count += change;
>
> set(count > 0);
set(count > 0);
looks so much better
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1210#discussion_r1298844201
