On Mon, 28 Aug 2023 04:58:31 GMT, Jayathirth D V <[email protected]> wrote:
> At multiple places in native glass code we don't have appropriate NULL checks
> which might result in null pointer access.
>
> Added appropriate checks and all test run is green.
modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line 270:
> 268: // we release this context in call_runnable
> 269: } else {
> 270: fprintf(stderr, "malloc failed in
> GtkApplication__1submitForLaterInvocatio\n");
if the malloc above failed, I would think there might be very serious errors
hence maybe this should be propagated to the Java layer, or throw the relevant
memory exception?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1223#discussion_r1307920910
