On Thu, 31 Aug 2023 20:22:09 GMT, Alexandre Iline <shurail...@openjdk.org> wrote:
> JDK-8315409: Fix jfx-tests so they work with latest jfx build The changes look reasonable to me. I'll rely on Ajit to sanity test it. I did note a few copyright issues that you might want to look at. At a minimum, the missing comma after the `2023` is needed everywhere. There are a few files without copyright headers, but many are preexisting, so unless you are otherwise touching those files, they can be done later. bigapps/SceneBuilderTest/src/scenebuilder/RunGUIBrowser.java line 1: > 1: package scenebuilder; Missing copyright header. functional/ControlsTests/src/javafx/factory/ControlsFactory.java line 2: > 1: /* > 2: * Copyright (c) 2014, 2023 Oracle and/or its affiliates. All rights > reserved. You need a comma after `2023`. tools/Jemmy/GlassImage/src/org/jemmy/image/glass/ClasspathGlassImageLoader.java line 2: > 1: /* > 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. Shouldn't the original copyright year of 2009 be retained? ------------- PR Review: https://git.openjdk.org/jfx-tests/pull/1#pullrequestreview-1605745165 PR Review Comment: https://git.openjdk.org/jfx-tests/pull/1#discussion_r1312252514 PR Review Comment: https://git.openjdk.org/jfx-tests/pull/1#discussion_r1312254922 PR Review Comment: https://git.openjdk.org/jfx-tests/pull/1#discussion_r1312264033
