On Wed, 6 Sep 2023 21:15:45 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > change test class name I left a few comments on the API docs. I tested this on Ubuntu 16.04 Linux (yes, I know it's old). It doesn't pick up a change to the theme, but only reports the new value the next time I run the program. The serious issue is that it crashes on exit running any JavaFX program. It hangs trying to write the hs_err file, so all I have is this console error: # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f0da9446b18, pid=10266, tid=10290 # # JRE version: Java(TM) SE Runtime Environment (19.0.2+7) (build 19.0.2+7-44) # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0.2+7-44, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64) # Problematic frame: # V [libjvm.so+0xc85b18] [error occurred during error reporting (printing problematic frame), id 0xb, SIGSEGV (0xb) at pc=0x00007f0da9ba8223] # Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport %p %s %c %d %P" (or dumping to /localhome/kcr/javafx/tmp/core.10266) # # An error report file with more information is saved as: # /localhome/kcr/javafx/tmp/hs_err_pid10266.log modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 637: > 635: > 636: /** > 637: * Returns the {@link Integer} instance to which the specified > key is mapped. I think you can use `@code` rather than `@link` since there is already a link generated to `Integer` in the method signature. modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 648: > 646: > 647: /** > 648: * Returns the {@link Double} instance to which the specified > key is mapped. Same comment here and below: I think you can use `@code` ------------- PR Review: https://git.openjdk.org/jfx/pull/1014#pullrequestreview-1614217820 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317854793 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317855515
