On Fri, 1 Sep 2023 14:31:49 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Better failure detection
>
> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeContentMemoryLeakTest.java
> line 116:
>
>> 114: System.out.println("iteration " + count + " Panels in
>> memory: "
>> 115: + panelCount + " fail "
>> + fail);
>> 116: assertFalse(fail > 2);
>
> I actually seen the number to shoot up to 38 (albeit with Thread.sleep(1)).
> I wonder if there is a better way to detect failure? May be the fact that
> the 'panelCount` is ever increasing is the sign of failure, whereas if at
> least one time it's dropping we have succeeded.
> Or perhaps look at the count when the test complete and fail if panelCount <
> (attempts / 2) or something
Any more comments on this test fix after updation @andy-goryachev-oracle ?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1228#discussion_r1319403741
