On Fri, 8 Sep 2023 06:38:54 GMT, Karthik P K <[email protected]> wrote:
>> Snapping introduces differences between computed values and snapped values,
>> so we need to use non-zero tolerance when checking for equality. The
>> maximum tolerance is (1 / scale) - one display pixel scaled back to the
>> local coordinates.
>>
>> The tests have been modified to use the scale-specific tolerance.
>>
>> Tested with macOS at scale 1.0 and win11 at scales (100%, 125%, 150%, 175%).
>
> tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewResizeColumnToFitContentTest.java
> line 69:
>
>> 67: @Test
>> 68: public void resizeColumnToFitContentTest() {
>> 69: double wid0 = table.getColumns().get(0).getWidth();
>
> The variable names are changed to make L75 and L77 single line? the previous
> name was easy to understand in my opinion.
yes, also I find it more readable: the wider the scope, the longer the name.
this might be a personal preference.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1234#discussion_r1319987627
