On Thu, 7 Sep 2023 16:41:23 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space >> (using Math.floor), see for instance >> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing >> methods Region.snapPortionX/Y(). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - review comments > - Merge remote-tracking branch 'origin/master' into ag.8311527.snap.inner > - tests > - Merge remote-tracking branch 'origin/master' into ag.8311527.snap.inner > - javadoc > - snap portion > - cleanup > - 8311527: snap inner space It's theoretical, because we haven't done a thorough evaluation as to whether such a layout would actually _need_ `snapInnerSpace` to correctly do snapping. You are hypothesizing that it would, but until we have a concrete use case to evaluate and test, it's just that -- a hypothesis. So my recommendation is not to withdraw this PR, but put it into Draft until we do the work needed to show that it is generally useful. We should keep this potential need in mind when we review your "Column Resizing With Fractional Scale" fix in PR #1156 and when we pursue the general issues of layout being explored in PR #1111. I think we'll have a better idea of whether we will need this once we do that. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1190#issuecomment-1711881553
