On Fri, 15 Sep 2023 19:21:54 GMT, Martin Fox <d...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 38 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8314906.behavior.test >> - cleanup >> - key modifier >> - Merge remote-tracking branch 'origin/8314906.behavior.test' into >> 8314906.behavior.test >> - win >> - platform util >> - disabled keypad tests >> - text area tests >> - docs >> - text area doc >> - ... and 28 more: https://git.openjdk.org/jfx/compare/84b57701...911e6d33 > > tests/system/src/test/java/test/javafx/scene/control/behavior/BehaviorRobotTestBase.java > line 196: > >> 194: "9", KeyCode.DIGIT9, >> 195: ".", KeyCode.PERIOD, >> 196: ",", KeyCode.COMMA > > On French layouts the DIGIT codes don't actually produce digits (you have to > hold down Shift) and there's no KeyCode.PERIOD (also a shifted character). > You don't seem to be using those characters but you might want to remove them > from this table so no one is tempted to use them in the future. Interesting. It is my understanding though that for the purposes of this test it should work as expected. I've added `TextAreaBehaviorRobotTest.testTyping()` - could you try running it with your setup please? @Test public void testTyping() throws Exception { execute( //addKeyListener(), "0123456789.,abracadabra", checkText("0123456789.,abracadabra", 23) ); } ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1327740081
