On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger <jgn...@openjdk.org> wrote:

> Please review these changes to the build timestamp and to the JavaFX runtime 
> version available in the system properties.

The fix and new test both look good. Testing is green.

Can you also change the following in 
[`UPDATING-VERSION.md`](https://github.com/openjdk/jfx/blob/4d9a8ebe3b0cddfef2a2e9df5915b0f0b8382207/UPDATING-VERSION.md)?

> ```
> modify the testMajorVersion method to increment the feature version number
> from `N` to `N+1`.
> ```

to something like:


modify the `FEATURE` variable to increment the feature version number
from `N` to `N+1`.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1253#pullrequestreview-1668138205

Reply via email to